New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc-wrapper: allow compilers to specify unsupported hardening modes #29483
Conversation
@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Ericson2314, @peti and @edolstra to be potential reviewers. |
f0b9ced
to
812dd28
Compare
Could you use camelCase? Otherwise looks fine to me. |
812dd28
to
a2db45f
Compare
This is not a mass rebuild, only few old compilers affected. Can we merge? |
a2db45f
to
0f9f6d1
Compare
Fixes: 0fd7ef6 ('clang_34: Disable hardening bits (NixOS#28543)')
0f9f6d1
to
6d97696
Compare
@Ericson2314 agreed, would be useful for various cross compiling situations. Ideally the compiler toolchains should be inteligently ignoring the hardening flags but they don't seem to do that. So hardening should fall into a category of non-functional build attributes where the builders should try to do as many of that as possible but ignore any which can not be achieved. |
@bnikolic Well, I wouldn't want it to be too seemless less we accidentally end up with less clean machine code. Making the opt-out static and determinable from Nix, not just bash/builders themselves, seems to me like a sweet spot. Do you agree that no SPP seems to be a stage-static thing in generally, or mingw stage static thing in particular? |
@Ericson2314 I'm not sure. I think it depends on whether SSP is in the glibc or as separate library but haven't look in a lot of detail -- will keep this in mind. |
Fixes: 0fd7ef6 ('clang_34: Disable hardening bits (#28543)')
Fixes #28543
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)cc @abbradar @dtzWill