python-cffi: fix test failures when using clang #29471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
added
6.topic: darwin
|
Thanks. Will you backport to stable if needed? |
FRidh
reviewed
Sep 16, 2017
| @@ -13,15 +13,14 @@ if isPyPy then null else buildPythonPackage rec { | |||
| propagatedBuildInputs = [ libffi pycparser ]; | |||
| buildInputs = [ pytest ]; | |||
|
|
|||
| patchPhase = '' | |||
| substituteInPlace testing/cffi0/test_ownlib.py --replace "gcc" "cc" | |||
There was a problem hiding this comment.
ohh, only see just now that this is removed. Not so sure about that. Will also cause quite a rebuild.
There was a problem hiding this comment.
pretty sure the NIX_CFLAGS_COMPILE attribute also causes a rebuild
There was a problem hiding this comment.
even when optional? Hmm, yea I think you're right.
LnL7
added
the
8.has: port to stable
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Should unblock nixpkgs-unstable, since nox depends on cffi.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)