Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: disallow arguments after double splat #4985

Merged
merged 1 commit into from Sep 16, 2017
Merged

Parser: disallow arguments after double splat #4985

merged 1 commit into from Sep 16, 2017

Conversation

asterite
Copy link
Member

@asterite asterite commented Sep 16, 2017 •
edited

Fixes #4965

@asterite asterite self-assigned this Sep 16, 2017
@asterite asterite changed the title Parser: disallow arguments after double splat. Fixes #4965 Parser: disallow arguments after double splat Sep 16, 2017
mverzilli
mverzilli reviewed Sep 16, 2017
View reviewed changes
src/compiler/crystal/syntax/parser.cr Outdated
if @token.keyword?(:out)
if found_double_splat
raise "out not allowed after double splat"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be a little more verbose here? Like:

out arguments are not allowed after double splats

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@mverzilli mverzilli merged commit eb1f102 into crystal-lang:master Sep 16, 2017
@mverzilli mverzilli added this to the Next milestone Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mverzilli mverzilli mverzilli approved these changes

Assignees

@asterite asterite

Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asterite @mverzilli