roswell: init at version 17.9.10.82 #29478
Conversation
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/roswell/roswell; | ||
| description = "lisp installer and launcher for major environments that just works"; |
There was a problem hiding this comment.
Capitalize the first letter of the description, https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes.
| name = "roswell-${version}"; | ||
| version = "17.9.10.82"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Use fetchFromGitHub?
{
src = fetchFromGitHub {
owner = "roswell";
repo = "roswell";
rev = "v${version}";
};
}Also fetchFromGitHub should be imported at the top instead of fetchgit, and may also need a different sha256 (not sure).
| sh bootstrap | ||
| ''; | ||
|
|
||
| nativeBuildInputs = [ autoconf automake curl ]; |
There was a problem hiding this comment.
What is curl used for here?
There was a problem hiding this comment.
It's checked for in configure.ac, looks like it is more of a runtime requirement. Probably should put it is Curl headers are required in source files.buildInputs, right?
There was a problem hiding this comment.
Probably, if it is referenced at runtime. Now, it won't actually matter unless build and host platform differ (and are incompatible, in which case curl would crash when invoked on the host machine).
There was a problem hiding this comment.
Even if it's just headers, I still think build inputs makes more sense, but if it isn't linking against anything or invoking anything then I suppose it's all the same.
There was a problem hiding this comment.
I've moved it, but haven't pushed my WIP yet.
|
I'm having a problem with NixOS. When roswell is first run it downloads SBCL into the Is there a standard solution to this problem? I'm looking into EDIT: |
|
@GrahamcOfBorg build roswell |
|
Success on x86_64-linux (full log) Attempted: roswell Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: roswell Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: roswell Partial log (click to expand)
|
There was a problem hiding this comment.
@CarlOlson Please confirm if you are still having trouble with glibc
|
@ryantm I haven't been using roswell, but I can look into this again. I've probably learned something since then. 🤷♂️ |
|
@CarlOlson any interest in continuing with this PR? |
|
Sorry, I've stopped using nix 🤷♂ |
|
No problem, thanks for the update |
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
Roswell is a popular Common Lisp tool, it should be part of nixpkgs.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)