Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qupzilla: init at 2.1.2 #29488

Closed
wants to merge 1 commit into from
Closed

qupzilla: init at 2.1.2 #29488

wants to merge 1 commit into from

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 17, 2017 •
edited

Motivation for this change

Adds qupzilla web browser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

QupZilla has been "adopted" as a KDE project and renamed to "Falkon". I have a WIP commit here that hasn't been merged yet: peterhoeg@f840941

I think we should merge qupzilla under the new name as that's where it's heading anyway.

Do you feel like adopting my wip bits and merging that with your work?

Note the use of FALKON_PREFIX instead of using sed which is cleaner and easier to maintain.

@disassembler
Copy link
Member Author

I think that's a great idea. Can you PR your version and I'll close this request? I was mostly doing this to help someone in irc last night.

@peterhoeg peterhoeg mentioned this pull request Sep 17, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@disassembler @peterhoeg @joachifm