Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: calling twice proc with extern didn't work #4983

Merged
merged 1 commit into from Sep 16, 2017
Merged

Fix: calling twice proc with extern didn't work #4983

merged 1 commit into from Sep 16, 2017

Conversation

asterite
Copy link
Member

It's a bit hard to explain why this fixes it. Some call was setting some property of a Def that later should be reset, but it was done incorrectly so the second time it didn't work.

To be honest, the codegen code related to is super messy and hard to understand, but this fixes it. I'd like to slowly improve the compiler's code (I'd actually like to rewrite it from scratch, but no time), but for now we can only fix things like this.

@asterite asterite self-assigned this Sep 16, 2017
@asterite asterite changed the title Fix #4982 Fix: calling twice proc with extern didn't work Sep 16, 2017
@mverzilli mverzilli added this to the Next milestone Sep 16, 2017
@mverzilli mverzilli merged commit 7f4ccff into crystal-lang:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants