logilab_common: 0.63.2 -> 1.4.1 #29486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Astroid and pylint still function? |
|
pylint definitely does. I ran it against some local python code and it
output a bunch of stuff I was doing wrong :) As for astroid, I'm not that
familiar with it but I was able to open python and `import astroid` after
running nix-shell -p python36Packages.astroid -I nixpkgs=./
…On Sun, Sep 17, 2017 at 3:05 AM Frederik Rietdijk ***@***.***> wrote:
Astroid and pylint still function?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29486 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAnvxcfggj-aJTRV4UuRK8FF5KOHotTaks5sjMSdgaJpZM4PaAM7>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes logilab_constraint build.
related to #28643
Attempted to get tests working, but tests require a library not in nixos that hasn't been updated for python 3.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)