Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea-community: 2017.2.2 -> 2017.2.4 #29473

Closed
wants to merge 1 commit into from
Closed

idea-community: 2017.2.2 -> 2017.2.4 #29473

wants to merge 1 commit into from

Conversation

jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Sep 16, 2017 •
edited

Motivation for this change

I've been using 2017.2.4 for the last three days and I did not notice any problems or regressions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jdanekrh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @volth and @Mic92 to be potential reviewers.

@NeQuissimus
Copy link
Member

I decided to merge #29591 instead. Thank you :)

@jirkadanek jirkadanek deleted the jd_idea-community branch September 21, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jirkadanek @mention-bot @NeQuissimus @joachifm @jiridanek