Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consider instance var as nilable if assigned before self access #4984

Merged
merged 1 commit into from Sep 16, 2017
Merged

Don't consider instance var as nilable if assigned before self access #4984

merged 1 commit into from Sep 16, 2017

Conversation

asterite
Copy link
Member

@asterite asterite commented Sep 16, 2017 •
edited

Fixes #4981

If an instance variable was already assigned (present in @vars) there's no need to check if self was used before that.

@asterite asterite changed the title Fix #4981 Don't consider instance var as nilable if assigned before self access Sep 16, 2017
@asterite asterite changed the title Don't consider instance var as nilable if assigned before self access Don't consider instance var as nilable if assigned before self access. Fixes #4981 Sep 16, 2017
@asterite asterite changed the title Don't consider instance var as nilable if assigned before self access. Fixes #4981 Don't consider instance var as nilable if assigned before self access Sep 16, 2017
@mverzilli mverzilli added this to the Next milestone Sep 16, 2017
@mverzilli mverzilli merged commit 611b5eb into crystal-lang:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mverzilli mverzilli mverzilli approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asterite @mverzilli