Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prison: mark broken with Qt < 5.7 #28699

Merged
merged 1 commit into from
Aug 29, 2017
Merged

prison: mark broken with Qt < 5.7 #28699

merged 1 commit into from
Aug 29, 2017

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Aug 29, 2017 •
edited

Motivation

prison is not expected to build with Qt 5.6.

Testing
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Aug 29, 2017
@ttuegel
Copy link
Member Author

ttuegel commented Aug 29, 2017

I have manually verified that no packages depend directly on libsForQt56.prison.

@ttuegel ttuegel merged commit 9952a89 into NixOS:master Aug 29, 2017
@ttuegel ttuegel deleted the prison branch August 29, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttuegel ttuegel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ttuegel