coredns: 005 -> 010 #28709
coredns: 005 -> 010 #28709
Conversation
|
@rushmorem, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rtreffer to be a potential reviewer. |
| }; | ||
|
|
||
| goDeps = ./deps.nix; |
There was a problem hiding this comment.
the build fails with:
go/src/github.com/coredns/coredns/core/dnsserver/config.go:8:2: cannot find package "github.com/mholt/caddy" in any of:
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/coredns/coredns/vendor/github.com/mholt/caddy (vendor tree)
/nix/store/dq8ck03naq26sfkz5q1ls44fpva4b00f-go-1.8.3/share/go/src/github.com/mholt/caddy (from $GOROOT)
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/mholt/caddy (from $GOPATH)
/nix/store/az356x1kp2gf6nglm479vkyyjvg5l0wx-govers-20150109-3b5f175/share/go/src/github.com/mholt/caddy
go/src/github.com/coredns/coredns/core/dnsserver/register.go:12:2: cannot find package "github.com/mholt/caddy/caddyfile" in any of:
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/coredns/coredns/vendor/github.com/mholt/caddy/caddyfile (vendor tree)
/nix/store/dq8ck03naq26sfkz5q1ls44fpva4b00f-go-1.8.3/share/go/src/github.com/mholt/caddy/caddyfile (from $GOROOT)
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/mholt/caddy/caddyfile (from $GOPATH)
/nix/store/az356x1kp2gf6nglm479vkyyjvg5l0wx-govers-20150109-3b5f175/share/go/src/github.com/mholt/caddy/caddyfile
go/src/github.com/coredns/coredns/core/zmiddleware.go:32:2: cannot find package "github.com/mholt/caddy/startupshutdown" in any of:
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/coredns/coredns/vendor/github.com/mholt/caddy/startupshutdown (vendor tree)
/nix/store/dq8ck03naq26sfkz5q1ls44fpva4b00f-go-1.8.3/share/go/src/github.com/mholt/caddy/startupshutdown (from $GOROOT)
/tmp/nix-build-coredns-010.drv-0/go/src/github.com/mholt/caddy/startupshutdown (from $GOPATH)
/nix/store/az356x1kp2gf6nglm479vkyyjvg5l0wx-govers-20150109-3b5f175/share/go/src/github.com/mholt/caddy/startupshutdown
builder for ‘/nix/store/dq7g3hb5hszqgd1cmj4jll0fr93dpvnb-coredns-010.drv’ failed with exit code 1
There was a problem hiding this comment.
you probably want to take a look at go2nix.
There was a problem hiding this comment.
the build fails...
you probably want to take a look at go2nix.
Yeah, I know. It's still WIP. When I decided to update this package, I noticed that it's now vendoring it's dependencies so I deleted deps.nix and removed goDeps only to discover that it's ignoring some dependencies when I tried to build. I don't have time to take care of this at the moment so I will let this sit for now.
|
@rushmorem are you still planning to working on this? There are a few newer versions available as well. Since a few days the current stable and unstable version (both 005) fail to build since the upstream tag seems to have been changed/updated: ( It would be great to either update, remove or at least resolve this issue 😃 (cc'ing the other maintainer @rtreffer) |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)