Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radicale_infcloud: init #29525

Merged
merged 1 commit into from Sep 19, 2017
Merged

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

Package https://github.com/Unrud/RadicaleInfCloud for use with Radicale.

Possibly of interest to @infinisil as the other radicale maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

sha256 = "1c9ql9nv8kwi791akwzd19dcqzd916i7yxzbnrismzw4f5bhgzsk";
};

doCheck = false; # Tries to import radicale, circular dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But radicale does not depend on this, right?
How does the circular dependency happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a plugin for radicale, so I haven't enabled it for default but radicale_infcloud would normally be added as a dependency for radicale, which would cause the circular dependency.

Also there don't seem to actually be any tests in the repository, so I don't think this is really missing anything.

buildPythonPackage rec {
pname = "radicale_infcloud";
name = "${pname}-${version}";
version = "972757bf4c6be8b966ee063e3741ced29ba8169f";
Copy link
Member

@Mic92 Mic92 Sep 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer date of commit here, since it is human readable and can be sorted by nix-env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I'm never sure about this, I've seen a bunch of conflicting recommendations for what to do for versions straight from VCS.

@Mic92 Mic92 merged commit 06de6d5 into NixOS:master Sep 19, 2017
@aneeshusa aneeshusa deleted the radicale_infcloud-init branch January 7, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants