tests: add initrd-network-ssh test #29528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpletz
reviewed
Sep 18, 2017
nixos/tests/dropbear.nix
Outdated
| ''; | ||
|
|
||
| in { | ||
| name = "dropbear"; |
There was a problem hiding this comment.
Technically, this is not testing the dropbear service but ssh support in the initrd. Why not name it initrd-ssh or initrd-network-ssh as initrd-network also exists?
nixos/tests/dropbear.nix
Outdated
| "${readFile keys.dbPub}" | ||
| ]; | ||
| }; | ||
| networking.usePredictableInterfaceNames = false; |
There was a problem hiding this comment.
Shouldn't be needed on the client.
nixos/tests/dropbear.nix
Outdated
| (head config.networking.interfaces.eth1.ip4).address | ||
| }:::255.255.255.0::eth1:none" | ||
| ]; | ||
| networking.usePredictableInterfaceNames = false; |
There was a problem hiding this comment.
Since you shutdown the server from the initrd on success, systemd will never be started which makes setting this option useless.
|
You also have to add the test do |
WilliButz
force-pushed
the
dropbear-test
branch
from
8a0acfb
to
fbf236c
Compare
starts two VMs: - one with dropbear listening from initrd, waiting for a file - another connecting via ssh, creating the file
WilliButz
force-pushed
the
dropbear-test
branch
from
fbf236c
to
f28c317
Compare
WilliButz
changed the title
|
@fpletz I updated the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starts two VMs:
waiting for a file
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)