Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-Term-Animation: init at 2.6 #29536

Closed
wants to merge 1 commit into from
Closed

Conversation

timor
Copy link
Member

@timor timor commented Sep 18, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

propagatedBuildInputs = [ Curses ];
meta = {
description = "ASCII sprite animation framework";
license = stdenv.lib.licenses.unknown;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ];

based on the README.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, this time I actually looked, but obviously didn't look in the right place :)

Will change

@rycee
Copy link
Member

rycee commented Sep 18, 2017

Cool! Rebased to master in ccfce4b.

@rycee rycee closed this Sep 18, 2017
@timor timor deleted the perl-Term-Animation branch September 19, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants