Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocode: 20170530 -> 20170903 #29534

Merged
merged 1 commit into from Sep 18, 2017
Merged

gocode: 20170530 -> 20170903 #29534

merged 1 commit into from Sep 18, 2017

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 18, 2017

Motivation for this change

Updated the software to the latest version to get around this issue: nsf/gocode#466

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz merged commit 8a40188 into NixOS:master Sep 18, 2017
@fpletz
Copy link
Member

fpletz commented Sep 18, 2017

Thanks for your first contribution to nixpkgs! Welcome on board. 🍻

@etu
Copy link
Contributor Author

etu commented Sep 19, 2017

Yay, thanks 😄

@etu etu deleted the update-gocode branch September 19, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @fpletz