Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.14.1 and nodejs 8.5.0 #29529

Merged
merged 2 commits into from Sep 22, 2017
Merged

libuv: 1.14.1 and nodejs 8.5.0 #29529

merged 2 commits into from Sep 22, 2017

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Sep 18, 2017

Motivation for this change

Nodejs 8.5.0 requires the latest version of libuv 1.14.1.

libuv changelog
nodejs release notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lo1tuma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gilligan, @vcunat and @cstrahan to be potential reviewers.

@lukateras
Copy link
Member

lukateras commented Sep 20, 2017 •
edited

Tested on NixOS. v8.5.0 has a new long-awaited API (fs.copyFile) so hopefully this gets merged soon ;-)

@offlinehacker offlinehacker merged commit e17e22d into NixOS:master Sep 22, 2017
@offlinehacker
Copy link
Contributor

Thanks!

@lo1tuma lo1tuma deleted the nodejs-8.5.0 branch September 22, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lo1tuma @mention-bot @lukateras @offlinehacker