Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnscrypt-wrapper module: fix permissions and options #29050

Merged
merged 1 commit into from Sep 6, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 6, 2017

Motivation for this change

When keys get refreshed a folder with the permissions of the root user
get created in the home directory of the user dnscrypt-wrapper. This
prevents the service from restarting.

In addition to that the parameters of dnscrypt-wrapper have
changed in upstream and in the newly packaged software.

Things done
  • Tested on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of the service
  • Fits CONTRIBUTING.md.

When keys get refreshed a folder with the permissions of the root user
get created in the home directory of the user dnscrypt-wrapper. This
prevents the service from restarting.

In addition to that the parameters of dnscrypt-wrapper have
changed in upstream and in the newly packaged software.
@joachifm joachifm added this to the 17.09 milestone Sep 6, 2017
@joachifm
Copy link
Contributor

joachifm commented Sep 6, 2017

cc @rnhmjoj

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this on my server right now but it looks ok.
Thank you!

@joachifm joachifm merged commit 9bb4005 into NixOS:master Sep 6, 2017
@joachifm
Copy link
Contributor

joachifm commented Sep 6, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants