trezor-agent: 0.9.0 -> 0.9.2 #28656
Closed
trezor-agent: 0.9.0 -> 0.9.2 #28656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @np |
FRidh
requested changes
Aug 29, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -27603,23 +27603,25 @@ EOF | |||
| trezor_agent = buildPythonPackage rec{ | |||
| name = "${pname}-${version}"; | |||
| pname = "trezor_agent"; | |||
| version = "0.9.0"; | |||
| version = "v0.9.2"; | |||
There was a problem hiding this comment.
if you need the v you can add it to rev. It shouldn't be here because this is part of the name.
jb55
force-pushed
the
bump/trezor-agent
branch
from
53d1e1e
to
cb52de5
Compare
|
ah thanks I always forget that. I've pushed a fix
|
trezor-agent now splits agents into different packages. This commit still points trezor_agent to the trezor-specific agent to maintain backwards compatibility. We should probably abstract this a bit into ledgernano_agent, keepkey_agent, etc
jb55
force-pushed
the
bump/trezor-agent
branch
from
cb52de5
to
ef5a485
Compare
|
a bunch of things changed since the original PR which simplified it a bunch! I rebased on master. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)