Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfsm: fix build with gcc 6 #29245

Merged
merged 1 commit into from Sep 11, 2017
Merged

qfsm: fix build with gcc 6 #29245

merged 1 commit into from Sep 11, 2017

Conversation

timor
Copy link
Member

@timor timor commented Sep 11, 2017

Motivation for this change

fixes one item in #28643

Things done

Built locally, ran the resulting binary.
Program runs as expected, but there was a segfault when exiting.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@aristidb aristidb merged commit 124b3c8 into NixOS:master Sep 11, 2017
aristidb pushed a commit that referenced this pull request Sep 11, 2017
@timor @aristidb
qfsm: fix build with gcc 6 (#29245)
9be724d
@timor timor deleted the qfsm-gcc6-fix branch September 11, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timor @aristidb