Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl-Data-Dumper: 2.154 -> 2.161 + build fix #29237

Closed
wants to merge 1 commit into from
Closed

perl-Data-Dumper: 2.154 -> 2.161 + build fix #29237

wants to merge 1 commit into from

Conversation

timor
Copy link
Member

@timor timor commented Sep 11, 2017

Motivation for this change

package is broken in 17.03, current 17.09, and master

Things done

removed the devdoc output, updated to latest version from CPAN

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timor
Copy link
Member Author

timor commented Sep 11, 2017

cc @rycee

@rycee rycee self-assigned this Sep 11, 2017
@rycee
Copy link
Member

rycee commented Sep 11, 2017

Rebased into master in dcdbe96. Thanks! Note, I had a look in the package and saw that it uses the Perl license so I amended the commit to have the correct license. Unfortunately Perl developers quite often skip inserting the right license and dependencies in the meta data and then nix-generate-from-cpan will produce subpar results :-(

@rycee rycee closed this Sep 11, 2017
@timor timor deleted the perl-Data-Dumper-2.161 branch September 11, 2017 16:12
@timor
Copy link
Member Author

timor commented Sep 11, 2017

would it be possible to backport this into 17.03?

@rycee
Copy link
Member

rycee commented Sep 11, 2017

Yes, I will get it into 17.03 and 17.09 as well. In the middle of another change but will do this right after :-)

@timor
Copy link
Member Author

timor commented Sep 11, 2017

Thanks!

@rycee
Copy link
Member

rycee commented Sep 11, 2017

In 17.03 and 17.09 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rycee rycee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timor @rycee