traefik: init at 1.3.8 #29243
traefik: init at 1.3.8 #29243
Conversation
|
I would prefer if |
|
Of course, I'll look into it. |
|
@Mic92 I have updated to building traefik from source. There are a couple of things which feel a little hacky, but I couldn't find any docs on how to go about it. I would appreciate any feedback on changes to make it more idiomatic. Thanks |
pkgs/servers/traefik/default.nix
Outdated
| buildInputs = [ go-bindata ]; | ||
| sourceRoot = "."; | ||
| postUnpack = '' | ||
| files=`ls` |
There was a problem hiding this comment.
Indent this multiline string by two spaces, and do the same for buildPhase and installPhase.
pkgs/servers/traefik/default.nix
Outdated
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://traefik.io; | ||
| description = "Træfik, a modern reverse proxy"; |
There was a problem hiding this comment.
The description should not start with the package name, so just "A modern reverse proxy" is good.
pkgs/servers/traefik/default.nix
Outdated
| buildInputs = [ go-bindata ]; | ||
| sourceRoot = "."; | ||
| postUnpack = '' | ||
| files=`ls` |
There was a problem hiding this comment.
Not sure if there is a nix way to do this but you probably at least want ls -A here to also get hidden files too. If find is available here (I'm not sure if it is?), then it may be more correct or robust to use it instead:
find . -maxdepth 1 -not -path . -not path ./traefik -exec mv {} traefik \;Otherwise if still using mv, it may be safer (in case of any 'unexpected' ls output, not sure) to use the -t option:
mv -t traefik $files
this way gethostbyname() works as indented
|
I reworked the package. Should be less hacky now. |
|
Maybe a nixos module? |
|
That is my next change, I'll start working on it |
Motivation for this change
Traefik is used as a reverse proxy alternative to other tools such as nginx/caddy.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)