Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning Openstack image builders #29242

Merged
merged 1 commit into from Sep 11, 2017
Merged

Cleaning Openstack image builders #29242

merged 1 commit into from Sep 11, 2017

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Sep 11, 2017

There are currently two ways to build Openstack image. This just picks
best of both, to keep only one!

  • Image is resizable
  • Cloudinit is enable
  • Password authentication is disable by default
  • Use the same layer than other image builders (ec2, gce...)
Motivation for this change
Things done

I built an image, upload it and successfully run it on an openstack cloud.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Cleaning Openstack image builders
7da9176 
There are currently two ways to build Openstack image. This just picks
best of both, to keep only one!

- Image is resizable
- Cloudinit is enable
- Password authentication is disable by default
- Use the same layer than other image builders (ec2, gce...)
@nlewo
Copy link
Member Author

nlewo commented Sep 11, 2017

cc @alexandergall @Mic92

@Mic92 Mic92 merged commit 3a377e2 into NixOS:master Sep 11, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017

Thanks!

fpletz pushed a commit that referenced this pull request Sep 17, 2017
@nlewo @fpletz
nixos/nova-image: cleanup image builders (#29242)
a6bf071 
There are currently two ways to build Openstack image. This just picks
best of both, to keep only one!

- Image is resizable
- Cloudinit is enable
- Password authentication is disable by default
- Use the same layer than other image builders (ec2, gce...)

(cherry picked from commit 3a377e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlewo @Mic92