Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buildbot wsgi dashboards plugin #29236

Closed
wants to merge 1 commit into from
Closed

Add buildbot wsgi dashboards plugin #29236

wants to merge 1 commit into from

Conversation

akazakov
Copy link
Contributor

@akazakov akazakov commented Sep 11, 2017 •
edited

  • Add buildbot wsgi dashboards plugin
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@akazakov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nand0p, @Twey and @copumpkin to be potential reviewers.

@akazakov
Copy link
Contributor Author

@copumpkin

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2017 •
edited

we already have this version, but not the plugin updates: #29235

@FRidh
Copy link
Member

FRidh commented Sep 11, 2017

cc maintainers @nand0p @ryansydnor

@akazakov akazakov changed the title Upgrade buildbot 0.9.9 -> 0.9.11 Add buildbot wsgi dashboards plugin Sep 12, 2017
@akazakov
Copy link
Contributor Author

@Mic92 thanks, updated the PR.

ryansydnor
ryansydnor approved these changes Sep 12, 2017
View reviewed changes
Copy link

@ryansydnor ryansydnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2017

commit message changed slightly and merged in 60709ab.
This plugin is also included in buildbot-full in 6844b13.

@Mic92 Mic92 closed this in 60709ab Sep 12, 2017
@copumpkin
Copy link
Member

Thanks!

fpletz pushed a commit that referenced this pull request Sep 17, 2017
@akazakov @fpletz
buildbot: add wsgi dashboards plugin
9bb3463 
fixes #29236

(cherry picked from commit 60709ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansydnor ryansydnor ryansydnor approved these changes

Assignees
No one assigned
Labels
6.topic: python 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@akazakov @mention-bot @Mic92 @FRidh @copumpkin @ryansydnor @Janik-Haag