Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_plugins: Use URLs for 1.0 if version is None #90

Merged
merged 1 commit into from Nov 20, 2017
Merged

download_plugins: Use URLs for 1.0 if version is None #90

merged 1 commit into from Nov 20, 2017

Conversation

mineo
Copy link
Member

@mineo mineo commented Sep 11, 2017

Otherwise, the branch name used was master, which doesn't exist in the
repository anymore.

Without this, running the test cases always fail because download_plugins was downloading files from the no longer existing master branch on GitHub.

@mineo
download_plugins: Use URLs for 1.0 if version is None
63c34bd 
Otherwise, the branch name used was master, which doesn't exist in the
repository anymore.
@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@zas zas merged commit 4a66084 into metabrainz:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mineo @brainzbot @zas