Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-wrapper: Remove deprecated parameters #28770

Merged
merged 2 commits into from Sep 1, 2017
Merged

cc-wrapper: Remove deprecated parameters #28770

merged 2 commits into from Sep 1, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 30, 2017 •
edited

Motivation for this change
  • NIX_CC_WRAPPER_START_HOOK
  • NIX_CC_WRAPPER_EXEC_HOOK
  • NIX_LD_WRAPPER_START_HOOK
  • NIX_LD_WRAPPER_EXEC_HOOK
  • NIX_LDFLAGS_HARDEN

None of these are no longer used by anything, anymore.

Things done

@edolstra signed off on the concept of the hook dead code removal. @fpletz agreed with the hardening dead code removal.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s) --- N.B. I haven't kicked off any yet, but it's just removing dead code
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
cc-wrapper: Remove {START,EXEC}_HOOK
46fd4bc 
These are no longer used by anything
@Ericson2314
cc-wrapper: Remove support for NIX_LDFLAGS_HARDEN
3d3a6e0 
It has long been deprecated
@Ericson2314 Ericson2314 added this to the 17.09 milestone Aug 31, 2017
@Ericson2314 Ericson2314 added this to Needed for binutils-wrapper in Cross compilation Aug 31, 2017
@Ericson2314 Ericson2314 changed the title cc-wrapper, binutils-wrapper: Remove wrapper hooks cc-wrapper: Remove deprecated parameters Aug 31, 2017
@Ericson2314 Ericson2314 merged commit 46d6fec into NixOS:staging Sep 1, 2017
@Ericson2314 Ericson2314 deleted the remove-wrapper-hooks branch September 1, 2017 00:04
@Ericson2314 Ericson2314 added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable A PR already has a backport to the stable release. labels Sep 1, 2017
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees

@fpletz fpletz

@globin globin

Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
No open projects
Cross compilation
Needed for binutils-wrapper
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @fpletz @samueldr @globin