Fixes #4765. When creating a symbolic link JRuby give bad error messa…

…ge when not an admin on windows
jruby · Aug 30, 2017 · b9b2e20 · b9b2e20
1 parent 89ed3b6
commit b9b2e20
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/src/main/ruby/jruby/kernel/file.rb b/core/src/main/ruby/jruby/kernel/file.rb
@@ -112,7 +112,11 @@ def self.symlink(target, link)
           wtarget = target.wincode
 
           unless CreateSymbolicLinkW(wlink, wtarget, flags)
-            raise SystemCallError.new('CreateSymbolicLink', FFI.errno)
+            errno = FFI.errno
+            # FIXME: in MRI all win calling methods call into a large map between windows errors and unixy ones.  We
+            # need to add that map or possibly expost whatever we have in jnr-posix
+            raise Errno::EACCES.new('File.symlink') if errno == 1314 # ERROR_PRIVILEGE_NOT_HELD
+            raise SystemCallError.new('File.symlink', errno)
           end
 
           0 # Comply with spec