Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4884
This PR changes the codegen in two ways:
Ideally point 2 should work for float constants too, but right now it doesn't because the math interpreter code only targets integers and it will be a much bigger refactor which can be tackled in a separate PR. Also, float constants are usually less common than integer ones.
So for example, compiling with
--prelude=empty --emit llvm-ir --no-debug
, for this code:Before:
After:
Likewise, for this:
Before it was a long chunk of LLVM code, now:
Note that this is without
--release
. That means it generates less code and supposedly will improve LLVM optimization times.