Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettext: libiconv should be a buildInput #28766

Merged
merged 1 commit into from
Aug 30, 2017
Merged

gettext: libiconv should be a buildInput #28766

merged 1 commit into from
Aug 30, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 30, 2017 •
edited

Motivation for this change

General correctness; removing a potential cross compilation bug.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS --- hash unchanged
    • macOS --- the one used in stdenv but not the rest of them
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added this to the 17.09 milestone Aug 30, 2017
@Ericson2314 Ericson2314 merged commit 22cd889 into NixOS:staging Aug 30, 2017
@Ericson2314 Ericson2314 deleted the gettext branch August 30, 2017 21:11
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Aug 30, 2017
@Ericson2314 Ericson2314 added this to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top in Cross compilation Aug 30, 2017
@Ericson2314 Ericson2314 added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable A PR already has a backport to the stable release. labels Sep 1, 2017
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees

@copumpkin copumpkin

@LnL7 LnL7

Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 8.has: port to stable A PR already has a backport to the stable release.
Projects
No open projects
Cross compilation
Needed by the big PR---nice to move p...
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @LnL7 @copumpkin @samueldr