Skip to content

Commit

Permalink
ucl: only pass -stc=c90 when using gcc
Browse files Browse the repository at this point in the history
Also remove -fPIC, it's included in the hardening flags by default.
  • Loading branch information
LnL7 committed Sep 6, 2017
1 parent 9efd7a9 commit 51eafbe
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkgs/development/libraries/ucl/default.nix
@@ -1,4 +1,4 @@
{stdenv, fetchurl}:
{ stdenv, fetchurl }:

stdenv.mkDerivation {
name = "ucl-1.03";
Expand All @@ -8,7 +8,7 @@ stdenv.mkDerivation {
};

# needed to successfully compile with gcc 6
NIX_CFLAGS_COMPILE = "-std=c90 -fPIC";
NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.cc.isGNU "-std=c90";

meta = {
homepage = http://www.oberhumer.com/opensource/ucl/;
Expand Down

1 comment on commit 51eafbe

@MP2E
Copy link

@MP2E MP2E commented on 51eafbe Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Will be sure to properly guard CFLAG changes in the future :)

Please sign in to comment.