skanlite: init at 2.0.1 #29060
skanlite: init at 2.0.1 #29060
Conversation
|
@pshendry, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @vandenoever and @peterhoeg to be potential reviewers. |
|
|
||
| enableParallelBuilding = true; | ||
|
|
||
| meta = with stdenv.lib; { |
|
Please split the commit into one commit per logical change (sane upgrade, libksane and skanlite). |
|
@vyp License added; I had used ktorrent as a template, which was missing a @peterhoeg Commits are split up |
|
@pshendry great, thanks for that. 🎉 |
| src = fetchurl { | ||
| sha256 = "0b3fvhrxl4l82bf3v0j47ypjv6a0k5lqbgknrq1agpmjca6vmmx4"; | ||
| sha256 = "1j9nbqspaj0rlgalafb5z6r606k0i22kz0rcpd744p176yzlfdr9"; |
There was a problem hiding this comment.
When I tried it on my system, I actually had to revert the hash back to its previous version.
So oddly the following combination worked for me:
version = "1.0.27";
src = fetchurl {
sha256 = "0b3fvhrxl4l82bf3v0j47ypjv6a0k5lqbgknrq1agpmjca6vmmx4";
|
I tried it on 17.09 and it builds and scans fine. Thank you :) The only issue I had was that I had to revert the sha265 for the sane-backends 1.0.27 for it to install. |
|
@silverhook Odd, do you get different files if you manually download the tarballs from the 1.0.25 and 1.0.27 URLs? |
|
@pshendry, I didn’t try. TBH, I’m fairly new to actually running NixOS (even though I’ve been following it for ages), so it very much might be that I messed something up. I also uninstalled the packages from your repo in the mean time. But does Skanlite actually depend on the new verison of sane-backends, or was that just a completely separate change? |
|
@silverhook I'm new to packaging, so I may be misunderstanding something as well. There's no hard requirement on libsane 1.0.27, that was just a drive-by upgrade while I was doing this, so if it comes down to it we can drop that commit. |
|
I've tried rebuilding this from scratch and it works fine for me, I'm not getting the issue @silverhook described. I'm back home with my scanner and the built binary works great (with a As far as I can tell it's ready to merge. |
|
Thank you for the contribution @pshendry! |
|
Awesome! \o/ I don’t see it in the 17.09 channel though. |
|
@silverhook It probably won't be in 17.09. Generally only bugfixes and important updates are backported after a release is branched off. |
|
17.09 is not released yet though is it? |
|
@vyp It is not released but it was branched off on August 30th. The point of branching off before release is to fix issues; making any unnecessary changes could create more. (Not that this would) |
|
Makes sense, I guess. |
|
@zraexy Thanks for clarifying! |
Motivation for this change
Adding skanlite, a popular KDE application
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Things remaining
I'm travelling right now and I don't have a scanner available, which means I can't really test the application apart from confirming that it launches. Could someone with a scanner check this out and try it?