scitools: init at 0.9.0 #29059
scitools: init at 0.9.0 #29059
Conversation
| version = "0.9.0"; | ||
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
This can be 'simplified' by using fetchFromGitHub instead:
{
src = fetchFromGitHub {
owner = "hplgit";
repo = "scitools";
rev = "${name}";
sha256 = "...";
};
}Just run nix-prefetch-url --unpack 'https://github.com/hplgit/scitools/archive/scitools-0.9.0.tar.gz' to get the sha256 (if it's different).
| buildInputs = [ matplotlib ]; | ||
| propagatedBuildInputs = [ numpy ]; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Add the license under meta here with license = stdenv.lib.licenses.bsd3;. And also add yourself as maintainer, maintainers = with stdenv.lib.maintainers; [ jamtrott ]; after adding yourself to https://github.com/NixOS/nixpkgs/blob/master/lib/maintainers.nix.
|
@vyp, Thanks for the review! The above two patches should address the issues. |
| sha256 = "07yxbc7spr7vy72lg3czv4r4q2f0wq17vszlnsfmsb2ix8jajp4d"; | ||
| }; | ||
|
|
||
| buildInputs = [ matplotlib ]; |
|
@jamtrott Are you still interested in implementing this? Before this is merged you would need to address remaining issues like using |
|
Hi, @veprbl. I don't need this package anymore, and I'm afraid that it's no longer being maintained anyway. I will close the pull request. Thank you all for your help. |
Motivation for this change
Add the scitools Python package, which contains many useful tools for scientific computing in Python.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)