openldap: Fix build with LibreSSL. #28457
Conversation
|
@mrobbetts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @DerTim1 and @chaoflow to be potential reviewers. |
|
It looks like the build failed simply because the output was too big. Glancing quickly, it looks like normal build output to me. Is this type of failure normal? |
|
This is a big rebuild, much larger than travis can handle. |
|
Ahh. Not intentional. Is there a way to fix it, or do you guys just ignore the failure for PRs like this one? |
|
Spurious/unrelated errors are ignored. |
|
Can you change the pull request from the |
| @@ -8,6 +8,14 @@ stdenv.mkDerivation rec { | |||
| sha256 = "091qvwk5dkcpp17ziabcnh3rg3m7qwzw2pihfcd1d5fdxgywzmnd"; | |||
| }; | |||
|
|
|||
| patches = [ | |||
| (fetchurl { | |||
| url = "https://bz-attachments.freebsd.org/attachment.cgi?id=183223"; | |||
There was a problem hiding this comment.
I... think so? It's linked from the bug tracker at:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219781
Clicking around, I find a link to it:
https://svnweb.freebsd.org/ports/head/net/openldap24-server/files/patch-libressl?revision=442605&view=co&pathrev=442605
Would this be more appropriate? I can change it if you think so.
There was a problem hiding this comment.
svn is better, use also fetchpatch instead of fetchurl for further normalization.
|
Changed base branch to |
Motivation for this change
openldapdoesn't build withLibreSSLas-is. This patch is pulled from upstream to fix it.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)