Fixing component handling for lcos #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a UB where the LCOs using (simple) components where cast to wrong types.
hkaiser
approved these changes
Aug 22, 2017
| protected: | ||
| hpx::performance_counters::counter_info info_; | ||
| util::atomic_count invocation_count_; | ||
| class base_performance_counter |
There was a problem hiding this comment.
This diff are reformating changes introduced by clang-format...
There was a problem hiding this comment.
We agreed not to reformat whole files without dire need...
There was a problem hiding this comment.
I have no problem reverting the formatting changes again. I'm not exactly sure what happened here. I use git clang-format which should only affect the direct changeset (in that case, a forward declaration was removed). The resulting diff is pretty awful...
added 2 commits
August 24, 2017 01:05
- Moving implementation of a simple component to component(_base) - Keeping using simple_component = component and friends for backwards compatbility.
Conflicts: hpx/runtime/components/server/simple_component_base.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a UB where the LCOs using (simple) components where cast to
wrong types.