Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam: use aspcud on darwin #29336

Closed
wants to merge 1 commit into from
Closed

opam: use aspcud on darwin #29336

wants to merge 1 commit into from

Conversation

winniequinn
Copy link
Contributor

Motivation for this change

aspcud is the recommended solver for OPAM and the aspcud package is now building properly on Darwin. As such, we can remove the special case for Darwin that required OPAM to fall back to the built-in solver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@winniequinn
opam: use aspcud on darwin
97306d9 
aspcud is the recommended solver for OPAM and the `aspcud` package is
now building properly on Darwin. As such, we can remove the special case
for Darwin that required OPAM to fall back to the built-in solver.
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Sep 14, 2017
@winniequinn
Copy link
Contributor Author

It looks like CI is failing due to csv 1.7 having a broken download URL. I do not believe anything I changed could have caused this but I'm reaching out to the maintainer regardless as it needs to be fixed.

@winniequinn
Copy link
Contributor Author

The csv-related issue is being tracked at Chris00/ocaml-csv#19.

@winniequinn
Copy link
Contributor Author

winniequinn commented Sep 20, 2017 •
edited

This is still temporarily broken because the nixpkgs OCaml csv package is still using the broken URL. Everything has been fixed upstream, albeit in a way that leaves us a bit stranded in terms of semver constraints (as the next newer version of csv is 2.0).

@winniequinn
Copy link
Contributor Author

I am closing this for now until I can fix all of the issues in related packages.

@winniequinn
Copy link
Contributor Author

The csv issues have been fixed in 1e9deaa. I will create a new PR.

@winniequinn winniequinn mentioned this pull request Sep 23, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@winniequinn @LnL7