New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pomegranate: init at 0.7.7 #29338
Conversation
@@ -0,0 +1,25 @@ | |||
{ stdenv, pythonPackages, fetchFromGitHub }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate parameters are required, not a single package set.
|
||
propagatedBuildInputs = with pythonPackages; [ numpy scipy cython networkx joblib ]; | ||
|
||
buildInputs = [ pythonPackages.nose ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkInputs
version = "0.7.7"; | ||
name = "${pname}-${version}"; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to fetch from GitHub instead of PyPI?
@FRidh fixed I think |
@FRidh Anything else to change? |
(cherry picked from commit 1d0c8f8)
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)