Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ld-wrapper: Use .dylib not .so on Darwin #29317

Closed
wants to merge 1 commit into from
Closed

ld-wrapper: Use .dylib not .so on Darwin #29317

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 13, 2017 •
edited

Motivation for this change

ld-wrapper in a few places assumes the extension of a dynamic lib. This makes it accurate on Darwin.

My sierra hack will use this. That I'd like to back-port to 17.09, so this should be too.

Things done

We could be relying on ld-wrapper not working correctly as intended in myriad ways. Best to test this one pretty well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @orivej

@Ericson2314
ld-wrapper: Use .dylib not .so on Darwin
88dd9c0 
ld-wrapper in a few places assumes the extension of a dynamic lib. This
makes it accurate on Darwin.
@orivej
Copy link
Contributor

orivej commented Sep 13, 2017

Why wouldn't you change the Sierra hack to use this in a second commit in this pull request?

@Ericson2314
Copy link
Member Author

@orivej I need to forward port it from 17.03 first.

@Ericson2314
Copy link
Member Author

We're getting a disallowed /nix/store/cjmkwjbyss5a5253d347bshnwmh58vyq-bootstrap-Libsystem/lib requisite in stdenv-darwin-boot-2 due to a new additional RPATH entry in libsystem. Hmm...

@LnL7
Copy link
Member

LnL7 commented Sep 13, 2017

Not sure if it's important, but there are a bunch of libraries that don't follow the convention for darwin and hardcode so. Perhaps this should look for both?

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Atemu
Copy link
Member

Atemu commented Feb 27, 2021

Is this still relevant on Big Sur?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 27, 2021
@Ericson2314
Copy link
Member Author

Well there seem to be both .so and .dylib on darwin depending on the package bothering to be conditional. Someone from @NixOS/darwin-maintainers should say whether whatever functionality ld-wrapper was doing here is useful for non-ELF, and if so I'll revive it else I'll just close it.

@stale
Copy link

stale bot commented Oct 1, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2021
@lucasew
Copy link
Contributor

lucasew commented Aug 24, 2022

Closing this as it is abandoned.

@lucasew lucasew closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@copumpkin copumpkin Awaiting requested review from copumpkin

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
1.severity: mass-darwin-rebuild 1.severity: mass-rebuild 2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Ericson2314 @orivej @LnL7 @mmahut @Atemu @lucasew @veprbl @7c6f434c