haskellPackages.tldr: fix build, add as a top-level package #29328
Conversation
|
|
||
| # the tests for shell-conduit on Darwin illegitimatey assume non-GNU echo | ||
| # see: https://github.com/psibi/shell-conduit/issues/12 | ||
| doCheck = !pkgs.stdenv.hostPlatform.isDarwin; |
There was a problem hiding this comment.
It might be possible to remedy this issue by adding pkgs.coreutils into testToolDepends for this package so that GNU echo is in $PATH. It's not essential ... just an idea.
There was a problem hiding this comment.
The problem is the reverse: because GNU echo is on the path, the tests don't find the behavior they expect on Darwin with Nix.
There was a problem hiding this comment.
Ah, I see. Sorry, I misread the comment above.
| # shell-conduit determines what commands are available at compile-time, so | ||
| # that tldr will not compile unless the shell-conduit it uses is compiled | ||
| # with git in its environment. | ||
| buildInputs = oldAttrs.buildInputs ++ [ pkgs.git ]; |
There was a problem hiding this comment.
Please use lib.addBuildTool to accomplish this instead of overrideAttrs.
|
Thanks for your review! I've fixed it up now. J/w: besides making the code look better (simpler and more consistent), which is definitely worth something, are there additional benefits of using the |
|
I don't think there's any major benefit except readability. |
|
Thanks again! |
Motivation for this change
The package previously did not work (on any platform)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)