Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.statgrab: fix #29297 system library dependency failure #29318

Closed
wants to merge 1 commit into from
Closed

haskellPackages.statgrab: fix #29297 system library dependency failure #29318

wants to merge 1 commit into from

Conversation

savannidgerinel
Copy link
Contributor

Motivation for this change

Attempting to install haskellPackages.statgrab results in a compile time failure because the underlying statgrab C library was not found:

Setup: Missing dependency on a foreign library:
* Missing (or bad) header file: statgrab.h
* Missing C library: statgrab
This problem can usually be solved by installing the system package that
provides this library (you may need the "-dev" version). If the library is
already installed but in a non-standard location then you can use the flags
--extra-include-dirs= and --extra-lib-dirs= to specify where it is.
If the header file does exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.
Things done
  • Tested using sandboxing (nix.useSandbox on Nix
    OS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https
    ://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) -- no binary executables generated from this
    package
  • Fits CONTRIBUTING.md.

cc @peti

statgrab depends on a system library named statgrab. In the nixpkgs
namespaces, this is actually nixpkgs.libstatgrab. However, that was not
being passed in to the statgrab package. Instead, a `statgrab` parameter
was being passed in and used as the system library dependency, but was
also being nulled out.

I changed the parameter to libstatgrab for clarity and to avoid
collisions with the haskell package, and removed the nulling out of the
statgrab parameter.
@savannidgerinel
Copy link
Contributor Author

This was an edit to an auto-generated file. I'll need to contact the maintainer directly to figure out how to actually solve this.

peti added a commit to NixOS/cabal2nix that referenced this pull request Sep 15, 2017
@peti
Copy link
Member

peti commented Sep 15, 2017

The issue is fixed in f07c8e9964b524f8d51be4a382118339b60582e6, which will be merged to the master branch in the next two or three days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants