lgtm

Does project flow with squash on merge, - or I need to do squashing/acceptance squashing.

LGTM. @Anton-Latukha maybe you want to squash it all into a single commit.

That is what I asked above.

Is there is no squash on merge enabled and no workflow to squash on merge in repository.

It seems life the natural way to move.

It is nature of someone who contribute pull request and waits on acceptance - to better it's pull request. To make fixes, add comments, polish, refactor code and text.

With squash on pull request contributor - he needs to squash all commits every time, at every fix, at every improvement, to keep things clean and ready to merge.

With squash on merge on maintainer side:

1. Maintainer doesn't need to write to me that I need to make squash.
2. Maintainer doesn't need to wait when and do I going to do squash.
3. Maintainer can chose by himself the name of commit. So standardized commit names can be enforced.
4. All can be done as maintainer wants, when maintainer wants.
5. It is already a GUI feature on GitHub. https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github

I created a relevant to this topic issue:

I was solving the real problem.

Most of scripts was in very poor state. And they do not have constants used. And they still do not.

I needed to merge at least something to have a progress in master.
To continue the work. To know that my things get accepted.

I offered myself to be a guy who would make a great quality Nix install scrips, and who would always give his time to maintain it.
My experience in community is great, except this Nix scripts.

I submitted 4 PRs. I've made a lot of reasoning for them, documentation, demo setups, etc. And nothing got merged. In 8 month.

If I can not get a tiniest changes. Changes that solve real world reported and myself experienced cases, like #971. Then, what can I do about that.

Now it can be cleaned up.

Anyway. Thanks to everybody.