Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.6.4 -> 4.6.7 #28864

Merged
merged 1 commit into from Sep 4, 2017
Merged

samba: 4.6.4 -> 4.6.7 #28864

merged 1 commit into from Sep 4, 2017

Conversation

mguentner
Copy link
Contributor

Motivation for this change

upgrade samba

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    Closure too big for my current system (would take a very long time)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mguentner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @abbradar to be potential reviewers.

@globin globin changed the base branch from master to staging September 4, 2017 20:35
@globin globin merged commit 2b928b4 into NixOS:staging Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mguentner @mention-bot @globin