Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: Track owners and followers #29399

Closed
wants to merge 1 commit into from
Closed

CODEOWNERS: Track owners and followers #29399

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Let's have our cake and eat it too?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Ericson2314 referenced this pull request Sep 14, 2017
@Profpatsch
Remove Profpatsch from the CODEOWNERS file
4cbe7bd 
Since CODEOWNERS shall be interpreted as actual ownership (and not just a
mentionbot replacement), I will remove myself again.
@Ericson2314 Ericson2314 assigned Phreedom and edolstra and unassigned Phreedom Sep 14, 2017
@Profpatsch
Copy link
Member

I recently noticed that the CODEOWNERS file is more integrated into Github than I initially thought. People can request reviews from code owners, and apparently this is actively proposed by the PR process.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Sep 14, 2017 •
edited

@Profpatsch I believe the reviews are requested unconditionally. edit nope, the names just appear by default.

@Ericson2314 Ericson2314 requested review from edolstra and removed request for edolstra September 14, 2017 22:28
@NeQuissimus
Copy link
Member

I am bit concerned with the maintainability of the indentation.

Is it possible to list paths twice? i.e.

=== Owners ===
lib/* @User1 @User2

===Followers===
lib/* @User3 @User4 @User5

@FRidh
Copy link
Member

FRidh commented Sep 15, 2017 •
edited

@NeQuissimus
From the example at https://help.github.com/articles/about-codeowners/

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner

@NeQuissimus
Copy link
Member

That is unfortunate...

@Ericson2314
Copy link
Member Author

NixOS/rfcs#19 however it lands will obsolete this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@edolstra edolstra Awaiting requested review from edolstra

Assignees

@edolstra edolstra

Labels
2.status: merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Ericson2314 @Profpatsch @NeQuissimus @FRidh @Phreedom @edolstra @c0bw3b