Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jedi: disable tests #29405

Merged
merged 3 commits into from Sep 15, 2017
Merged

jedi: disable tests #29405

merged 3 commits into from Sep 15, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 14, 2017

Motivation for this change

Same exact failures as here: davidhalter/jedi#808

Suggestion is to use tox, but tox doesn't work with nixos, so disabling tests until it does.

Related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh and @Mic92 to be potential reviewers.

@disassembler
Copy link
Member Author

A lot of nox failures are broken already. Going through the list and fixing them as well in this PR.

@FRidh FRidh merged commit f5ea99f into NixOS:master Sep 15, 2017
FRidh added a commit that referenced this pull request Sep 15, 2017
jedi: disable tests
(cherry picked from commit f5ea99f)
@FRidh
Copy link
Member

FRidh commented Sep 15, 2017

Thanks!

@disassembler
Copy link
Member Author

nox-review passes, all dependencies fixed. This also fixes elpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants