Don't find type parameter T of generic type that's not the current type #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
changed the title
asterite
changed the title
RX14
requested changes
Sep 15, 2017
| @@ -25,6 +25,9 @@ class Crystal::Type | |||
| # If *free_vars* is given, when resolving a Path, types will be first searched | |||
| # in the given Hash. | |||
| # | |||
| # If *find_root_generic_type_parameters* is `true` (the default), type parameters | |||
| # relative to `self_type` will be found. If `false`, they won't be find. | |||
mverzilli
approved these changes
Sep 15, 2017
RX14
approved these changes
Sep 15, 2017
|
I like these two commits, could you squash the typo fix so we can rebase this onto master as 2 commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in the commit for an explanation of the problem and the solution.
Fixes #4460
Fixes #4604