Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ethereum: 1.6.7 -> 1.7.0 #29408

Closed
wants to merge 1 commit into from
Closed

go-ethereum: 1.6.7 -> 1.7.0 #29408

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Sep 15, 2017 •
edited

Motivation for this change

Upstream update

Also added myself as maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@adisbladis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @chris-martin, @dbrock and @infinisil to be potential reviewers.

@mbrock mbrock mentioned this pull request Sep 15, 2017
Closed
8 tasks
@rycee
Copy link
Member

rycee commented Sep 15, 2017

Rebased to master in 090947b. Thanks!

@rycee rycee closed this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @mention-bot @rycee