Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add buildGo19Package and use as default #29411

Closed
wants to merge 1 commit into from
Closed

add buildGo19Package and use as default #29411

wants to merge 1 commit into from

Conversation

alicebob
Copy link
Contributor

@alicebob alicebob commented Sep 15, 2017 •
edited

Motivation for this change

buildGoPackage still uses Go 1.8, while Go 1.9 is the new default.

Go 1.9 was introduced in 3189b01 by @cstrahan

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Sep 17, 2017

See #29173

@alicebob
Copy link
Contributor Author

github search doesn't seem that useful :/

Closed since it's a duplicate. Thanks @orivej !

@alicebob alicebob closed this Sep 17, 2017
@alicebob alicebob deleted the buildgo19package branch September 17, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alicebob @orivej