abcMIDI: init at 2017.06.10 #29412
Closed
abcMIDI: init at 2017.06.10 #29412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Sep 15, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -13381,6 +13381,8 @@ with pkgs; | |||
| libcdio = libcdio082; | |||
| }; | |||
|
|
|||
| abcmidi = callPackage ../applications/audio/abcmidi { }; | |||
There was a problem hiding this comment.
If I understand it correctly then abcmidi is mostly a collection of command line tools. If so then I would suggest to use ../tools/audio/abcmidi instead. See 12.3.1. Hierarchy in the Nixpkgs manual.
There was a problem hiding this comment.
You're absolutely correct. Corrected that.
Meanwhile, I don't really get the ordering in all-packages.nix.
There was a problem hiding this comment.
It is … complicated. Basically, stick your thing in roughly the right place and don't worry about it.
|
Rebased to master in 608045a. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)