NixOS Manual: document assertions and warnings #29206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roberth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatdocslady, @copumpkin and @ericsagnes to be potential reviewers. |
fpletz
reviewed
Sep 10, 2017
| "Importing <nixpkgs/nixos/modules/programs/virtualbox.nix> is " | ||
| + "deprecated, please use `virtualisation.virtualbox.host.enable = true' " | ||
| + "instead." ]; | ||
| config.virtualisation.virtualbox.host.enable = true; |
There was a problem hiding this comment.
Even though this is example is very concise, having the same structure here as below for assertions would be more clearer I think.
fpletz
approved these changes
Sep 10, 2017
fpletz
added
6.topic: nixos
8.has: documentation
9.needs: port to stable
domenkozar
approved these changes
Sep 10, 2017
roberth
force-pushed
the
nixos-manual-assertions-warnings
branch
from
552a924
to
5bb059b
Compare
|
Ok, I have simplified the assertion example and I have adapted the warning example to match the assertion example more closely. In doing so, the warning example is not a real world example any more. It turns out that they are not used very often. Most of the warnings seem to be deprecations, moves and such, which are modeled differently. |
|
Thanks! |
fpletz
pushed a commit
that referenced
this pull request
Sep 17, 2017
* NixOS Manual: document assertions and warnings * NixOS manual: re-wrap assertions text (cherry picked from commit 1b1fc65)
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
assertions and warnings in NixOS modules were not documented yet.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)