Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] linux_custom: Allow custom modDirVersion #29216

Closed
wants to merge 1 commit into from
Closed

[WIP] linux_custom: Allow custom modDirVersion #29216

wants to merge 1 commit into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Without this change, you cannot use "x.y.0" kernels because their version is "x.y" while the modDirVersion needs to be "x.y.0".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Sep 10, 2017

Maybe the inner kernel build function should just expand x.y to x.y.0? Another thing less to worry in the common case...

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Sep 10, 2017 •
edited

@dezgeg I sort of do that here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/kernel/linux-hardened-copperhead.nix Maybe I will push that logic into generic.nix

@NeQuissimus NeQuissimus changed the title linux_custom: Allow custom modDirVersion [WIP] linux_custom: Allow custom modDirVersion Sep 10, 2017
@dezgeg
Copy link
Contributor

dezgeg commented Sep 14, 2017

Maybe something like https://github.com/NixOS/nixpkgs/compare/master...dezgeg:kernel-auto-moddirversion?expand=1?

@NeQuissimus
Copy link
Member Author

To be fair, I would prefer the solution I have over the regex. Just a personal dislike for regex'.
I can do this when I find some time or you can just supersede this PR with one of your own. I don't mind.

@NeQuissimus NeQuissimus deleted the kernel_custom_moddir branch February 14, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @dezgeg