Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde_workspace: Adds missing buildInputs #29219

Closed
wants to merge 1 commit into from
Closed

kde_workspace: Adds missing buildInputs #29219

wants to merge 1 commit into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 10, 2017 •
edited

Motivation for this change

Progress on: #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bkchr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Phreedom, @edolstra and @vcunat to be potential reviewers.

@FRidh FRidh added this to the 17.09 milestone Sep 12, 2017
@peterhoeg
Copy link
Member

I think @ttuegel is planning on removing all KDE4 bits.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2017

Ahh, okay, I was unsure about that. But, I also think it is better to remove kde4 :)

@ttuegel
Copy link
Member

ttuegel commented Sep 13, 2017

The plan is to remove the last KDE4 packages in December 2017 because at that time, KDE will stop updating kdelibs4. Until then, I have been removing pieces that are no longer needed. If kde_workspace is not required by any other package, we should just remove it; otherwise, we should get it back in working condition for now.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2017

I think kde telepathy is the last package that depends on kde_workspace.

@ttuegel
Copy link
Member

ttuegel commented Sep 13, 2017

Then we should probably remove both. Neither KDE Telepathy, nor Telepathy itself, have been maintained for some time.

@bkchr bkchr mentioned this pull request Sep 14, 2017
Merged
8 tasks
@fpletz
Copy link
Member

fpletz commented Sep 18, 2017

Obsolete due to #29369.

@fpletz fpletz closed this Sep 18, 2017
@bkchr bkchr deleted the kde_workspace_fixes branch September 19, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bkchr @mention-bot @peterhoeg @ttuegel @fpletz @FRidh