Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow for python3.6 #29209

Merged
merged 1 commit into from Sep 12, 2017
Merged

tensorflow for python3.6 #29209

merged 1 commit into from Sep 12, 2017

Conversation

akamaus
Copy link
Contributor

@akamaus akamaus commented Sep 10, 2017

Motivation for this change

Right now tensorflow is unusable in release-17.09 due to #29154, why not to support default python36 then?

Things done
  • Built on platform(s)
    • NixOS
  • [X ] Tested execution of all binary files (usually in ./result/bin/)
  • [X ] Fits CONTRIBUTING.md.

Google publishes prebuilt tensorflow whl for python 3.4, 3.5, 3.6,
but nix expression for tensorflow only supported 3.5.
This change adds support for python-3.6.
@mention-bot
Copy link

@akamaus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jyp, @FRidh and @edwtjo to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Sep 10, 2017

cc @jpbernardy

@FRidh
Copy link
Member

FRidh commented Sep 11, 2017

cc @jyp Could you update the handle you use in Nixpkgs?

@jyp
Copy link
Contributor

jyp commented Sep 12, 2017

I agree that we should move to python 3.6

@jyp
Copy link
Contributor

jyp commented Sep 12, 2017

@FRidh See #29263

@edwtjo edwtjo merged commit eb7b9e1 into NixOS:release-17.09 Sep 12, 2017
@edwtjo
Copy link
Member

edwtjo commented Sep 12, 2017

LGTM, cherry-picked to master 6abb29f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants